Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for running os commands as a new release action #70

Conversation

JosephKav
Copy link
Collaborator

@JosephKav JosephKav commented May 26, 2022

Suggestion from reddit. Formatting of commands takes a bit of getting you to. You give it a command, then arguments. So to ls -lah /tmp, you'd need to do:

commands:
  - [ "ls", "-lah", "/tmp" ]

[ "ls", "-lah /tmp" ] doesn't work

Have added -test.commands SERVICE_NAME that would let you test these commands

fixes #32

@JosephKav JosephKav added the enhancement New feature or request label May 26, 2022
@JosephKav JosephKav linked an issue May 26, 2022 that may be closed by this pull request
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch from 8b9561d to 6fe49c0 Compare May 26, 2022 00:14
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch from 6fe49c0 to 06b082b Compare May 26, 2022 00:24
@JosephKav JosephKav force-pushed the master branch 2 times, most recently from 51a0c1c to 2e269df Compare May 27, 2022 00:07
@JosephKav JosephKav closed this May 27, 2022
@JosephKav JosephKav deleted the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch May 27, 2022 15:51
@JosephKav JosephKav restored the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch May 27, 2022 15:51
@JosephKav JosephKav reopened this May 27, 2022
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch 3 times, most recently from c0ee87e to 99f52bd Compare May 29, 2022 04:09
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch from 99f52bd to 4da3021 Compare May 29, 2022 05:23
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch 3 times, most recently from 4cd9497 to 5a2287a Compare May 29, 2022 18:24
- improved tooltips to be command specific if there's no webhooks
- added `ResetFails` to be used when `DeployedVersion` changes
^ so that successful commands/webhooks can be ran again on a new release
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch from 5a2287a to 943340b Compare May 29, 2022 19:08
@JosephKav JosephKav force-pushed the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch from 26e3f65 to 0e7a068 Compare June 1, 2022 19:26
@JosephKav JosephKav merged commit 9f4e599 into master Jun 2, 2022
@JosephKav JosephKav deleted the 32-feat-support-for-running-bash-commands-as-a-new-release-action branch June 2, 2022 12:58
JosephKav added a commit that referenced this pull request Jun 2, 2022
* feat: support for running commands on new release

* test: command tests

* feat(ui): see/approve commands

* feat: show resend button when only commands are defined (no webhooks)

- improved tooltips to be command specific if there's no webhooks
- added `ResetFails` to be used when `DeployedVersion` changes
^ so that successful commands/webhooks can be ran again on the next new release

* fix: reset webhook/command fail status on new `latestVersion`

* feat(ui): show in config

* fix(deployed_version): can get without `latest_version` being found
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Support for running bash commands as a new release action
1 participant