NCL-5717: Remove nexus-staging-maven-plugin by default #783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dwalluck
changed the title
dwalluck
commented
Oct 5, 2020
core/src/test/java/org/commonjava/maven/ext/core/impl/InitialGroovyManipulatorTest.java
Outdated
Show resolved
Hide resolved
dwalluck
commented
Oct 5, 2020
.../main/java/org/commonjava/maven/ext/core/impl/NexusStagingMavenPluginRemovalManipulator.java
Outdated
Show resolved
Hide resolved
dwalluck
force-pushed
the
NCL-5717
branch
2 times, most recently
from
2822bc8
to
1e12ec6
Compare
rnc
reviewed
Oct 5, 2020
.../main/java/org/commonjava/maven/ext/core/impl/NexusStagingMavenPluginRemovalManipulator.java
Outdated
Show resolved
Hide resolved
rnc
reviewed
Oct 5, 2020
core/src/main/java/org/commonjava/maven/ext/core/state/NexusStagingMavenPluginRemovalState.java
Show resolved
Hide resolved
rnc
reviewed
Oct 5, 2020
core/src/main/java/org/commonjava/maven/ext/core/state/PluginRemovalState.java
Outdated
Show resolved
Hide resolved
rnc
reviewed
Oct 5, 2020
integration-test/src/it/nexus-staging-maven-plugin-removal-disabled/invoker.properties
Outdated
Show resolved
Hide resolved
|
Looks good, I like the idea of reusing the removal code, just some minor comments for cleanup I think. Thanks! |
rnc
reviewed
Oct 5, 2020
core/src/main/java/org/commonjava/maven/ext/core/impl/PluginRemovalManipulator.java
Show resolved
Hide resolved
rnc
reviewed
Oct 5, 2020
.../main/java/org/commonjava/maven/ext/core/impl/NexusStagingMavenPluginRemovalManipulator.java
Outdated
Show resolved
Hide resolved
dwalluck
force-pushed
the
NCL-5717
branch
2 times, most recently
from
09c34d8
to
01ace96
Compare
rnc
requested changes
Oct 5, 2020
core/src/main/java/org/commonjava/maven/ext/core/state/NexusStagingMavenPluginRemovalState.java
Outdated
Show resolved
Hide resolved
|
@dwalluck I've taken a look at what is wrong and figured out one of the failures. The integration test failures elsewhere are baffling - they pass without your PR but your PR doesn't touch that area! |
|
Ok got it. If you cherry-pick the range of changes from https://github.com/rnc/pom-manipulation-ext/tree/NEXUS-ABSTRACT-PLUGIN that should solve it. The crucial ones are: I made the deploy location consistent in During debugging I was even wondering if the extending another plugin was causing the behaviour which is why the refactor happened ... that isn't strictly necessary now I think (although no harm per se) |
rnc
approved these changes
Oct 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.