Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCL-7343: Add ability to inject dependencies #936

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

rnc
Copy link
Contributor

@rnc rnc commented Sep 29, 2022

Signed-off-by: Nick Cross ncross@redhat.com

Signed-off-by: Nick Cross <ncross@redhat.com>
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 83.83% // Head: 83.87% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (81ed3f5) compared to base (fa15710).
Patch coverage: 92.10% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #936      +/-   ##
============================================
+ Coverage     83.83%   83.87%   +0.04%     
- Complexity     1903     1916      +13     
============================================
  Files           118      120       +2     
  Lines          7013     7051      +38     
  Branches       1204     1207       +3     
============================================
+ Hits           5879     5914      +35     
  Misses          662      662              
- Partials        472      475       +3     
Impacted Files Coverage Δ
...en/ext/core/impl/DependencyRemovalManipulator.java 90.74% <ø> (ø)
...ven/ext/core/impl/ProfileInjectionManipulator.java 95.45% <ø> (ø)
...maven/ext/core/state/DependencyInjectionState.java 85.71% <85.71%> (ø)
.../ext/core/impl/DependencyInjectionManipulator.java 93.54% <93.54%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rnc rnc merged commit ac9d7fc into release-engineering:main Sep 29, 2022
@rnc rnc deleted the NCL7343 branch September 29, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant