Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong success message for 'RemoveStudyUserRole' #114

Closed
chae-reliatec opened this issue Jan 23, 2020 · 2 comments · Fixed by #336
Closed

wrong success message for 'RemoveStudyUserRole' #114

chae-reliatec opened this issue Jan 23, 2020 · 2 comments · Fixed by #336
Assignees
Labels
maintenance Dependency management and legacy code cleanups

Comments

@chae-reliatec
Copy link
Member

chae-reliatec commented Jan 23, 2020

when a user with study role 'Data Manager' is removed the success message is:

user t010_01(user name: user_t010_01) has been removed from the Study/Site Libre Clinica Test Study with role coordinator. The user will no longer have access to the Study.

Instead of 'coordinator' the correct role 'Data Manager' should be shown.

The issue can be reproduced by following the instructions of T010_03

@chae-reliatec chae-reliatec added the bug Something isn't working label Jan 23, 2020
@chae-reliatec chae-reliatec added this to the LibreClinica-1.0 milestone Jan 23, 2020
@oba-reliatec oba-reliatec removed this from the LibreClinica-1.0 milestone Feb 13, 2020
@toskrip toskrip added maintenance Dependency management and legacy code cleanups and removed bug Something isn't working labels May 24, 2022
@toskrip
Copy link
Collaborator

toskrip commented May 24, 2022

This is because it uses the database name for the role rather then internationalised labels (site_Study_Coordinator, Study_Coordinator) from term.properties.

@toskrip
Copy link
Collaborator

toskrip commented May 24, 2022

The same on set role and restore role. There it influences not just alert message but also the view.

@toskrip toskrip self-assigned this May 24, 2022
@toskrip toskrip added this to the LibreClinica-1.2 milestone May 24, 2022
@toskrip toskrip linked a pull request May 25, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Dependency management and legacy code cleanups
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants