Thresholds: NC Notification and color coding

[Rello]

No description provided.

[Rello]

[Rello]

Hello @nickvergessen

I implemented notifications but I am receiving an error in NC16 - I assume its due to NC17.
Is there a complatibility to work with both or do I need to limit to NC17 now?

Call to undefined method OC\\Notification\\Manager::registerNotifierService()

its in Application.php
\OC::$server->getNotificationManager()->registerNotifierService(Notifier::class);

[nickvergessen]

No, it's not possible to be compatible with 16 and 17 at the same time

[nickvergessen]

You would need to have a second Notifier (call it Notifier16) and register with registerNotifier on the notification manager when that method is available. Or you tell your users that there is cool notifications when they update to 17 and you simply dont register on 16.

[Rello]

ok, but how do "not register" with NC16? I would go that route. currently NC17 dependency brakes in total.

and: could you do me a favour and check my implementation to avoid any obvious mistakes? would really be a help
https://github.com/Rello/analytics/blob/c5a2d1db4487d3f9e589e8ddef0632bcf90e5b42/lib/Notification/NotificationManager.php

https://github.com/Rello/analytics/blob/c5a2d1db4487d3f9e589e8ddef0632bcf90e5b42/lib/Notification/Notifier.php

[nickvergessen]

analytics/lib/AppInfo/Application.php

Line 34 in c5a2d1d

\OC::$server->getNotificationManager()->registerNotifierService(Notifier::class);

Replace with:

$notificationManager = \OC::$server->getNotificationManager();
if (method_exists($notificationManager, 'registerNotifierService')) {
    \OC::$server->getNotificationManager()->registerNotifierService(Notifier::class);
}

And do the same where you "create" the notification

[Rello]

https://www.youtube.com/watch?v=qnNZafE7ECM

@nickvergessen thank you for your help. next milestone reached!

[Rello]

Information: Notifications only working as of NC17