Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide option to filter contributors #32

Closed
4 tasks done
donmahallem opened this issue Aug 16, 2021 · 5 comments
Closed
4 tasks done

Provide option to filter contributors #32

donmahallem opened this issue Aug 16, 2021 · 5 comments
Labels
💪 phase/solved Post is done

Comments

@donmahallem
Copy link

Initial checklist

Problem

Currently only greenkeeper is statically ignored in the list of contributors but other "popular" Github Bots aren't.

Solution

As it would be cumbersome to statically programm "every" bot contributor to the source I propose adding a "Default" list of ignored accounts and adding a property/array to the plugin options which describe the ignored accounts.

One option would be to use "simple" descriptors like:

{ name?:string,mail?:string}

Alternatives

Another option would be to use json-schemas to go the extra mile.

@github-actions github-actions bot added 👋 phase/new Post is being triaged automatically 🤞 phase/open Post is being triaged manually and removed 👋 phase/new Post is being triaged automatically labels Aug 16, 2021
@wooorm
Copy link
Member

wooorm commented Aug 16, 2021

don’t bots nowadays all have a [bot] suffix in their username? Could we use that?

@donmahallem
Copy link
Author

You are right. But for older repos there are still other non [bot] bot contributors. For example dependabot. I believe there should still be an option to provide additional exclusions. In general filtering by [bot] suffix should be good enough to catch most general cases.

@wooorm
Copy link
Member

wooorm commented Aug 23, 2021

Could there be a case in favor of including bots? 🤔

Generally I think you’re right that this is a good addition. Not 100% on how to do it though?

@donmahallem
Copy link
Author

@wooorm there is.

Options could be

  1. Default Bot Block list, which can be overwritten/disabled/expanded
  2. No default Block List

In either case there should be a way to specify a regex/match list for relevant properties like username or mail.

Optionally providing filter functions to the plugin isn't encouraged probably?

@wooorm wooorm closed this as completed in f05fbda Sep 23, 2024
@wooorm wooorm added the 💪 phase/solved Post is done label Sep 23, 2024
@github-actions github-actions bot removed the 🤞 phase/open Post is being triaged manually label Sep 23, 2024
@wooorm
Copy link
Member

wooorm commented Sep 23, 2024

Released in 5.1.0!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 phase/solved Post is done
Development

No branches or pull requests

2 participants