Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

posibility of a 8.0.4 release with less strict trim version dependecy #710

Closed
salzig opened this issue May 11, 2021 · 9 comments
Closed
Labels
🙉 open/needs-info This needs some more info 🐛 type/bug This is a problem

Comments

@salzig
Copy link

salzig commented May 11, 2021

Subject of the issue

The 8.0 branch of remark-parse requires trim in verison "0.0.1", which has a security problem (see: https://www.npmjs.com/advisories/1700).

Is there any posibility that you could release an update to 8.0.3 (ie 8.0.4) that introduces a less strict version dependency for trim?

@wooorm
Copy link
Member

wooorm commented May 11, 2021

This is unlikely to affect you. You could use patch-package if you have to support old remark to get around it. Or update to remark@13. mdx-js/mdx@next and most of the ecosystem has updated already

@wooorm
Copy link
Member

wooorm commented May 11, 2021

More of an mdx-js/mdx issue: you’ve seen the reports and results there.

@wooorm wooorm closed this as completed May 11, 2021
@salzig
Copy link
Author

salzig commented May 11, 2021

except remark-mdx@1.6.22 which is used by @mdx-js/mdx@1.6.22 which is used by @storybook/addon-docs@6.2.9.

A patch release of remark-parse with a less strict version dependency for trim would allow me to reopen the @mdx-js/mdx#1548 issue, so they could introduce a less strict version dependency.

@salzig
Copy link
Author

salzig commented May 11, 2021

I'm amazed. Is releasing a patch version that opens for patch updates of "trim" really that hard to accomplish that it is instead suggested to use unstable "next"-releases?

EDIT: even if that is your opionion, i would still consider hart patchlevel pinning of dependency a bug, as this is blocking potential security updates.

@wooorm
Copy link
Member

wooorm commented May 11, 2021

It's impossible to not pin 0.0.1. I raised that 5 years ago: component/trim#7 (comment)

@ChristianMurphy
Copy link
Member

that it is instead suggested to use unstable "next"-releases?

As noted in mdx-js/mdx#1548 (comment), MDX 2 is one option.
XDM is another, and does have remark-parse 9+ on a stable release.

blocking potential security updates.

Please read the advisory https://www.npmjs.com/advisories/1700
This is not an exploit, it is a potential slow down.
remark-parse 9 and mdx 2/xdm include performance improvements for this, and other performance improvements.

@salzig
Copy link
Author

salzig commented May 11, 2021

This is not an exploit, it is a potential slow down.

This is true for this situation. But still it would be a lot nicer/easier to have a way to handle this without doing a major update, which makes a lot of people, especially QA-People, nervous

It's impossible to not pin 0.0.1. I raised that 5 years ago

oh man, what a strange part of our dependcy tree. I think we need to prioritize some updates for our app.

@MoSattler
Copy link

It's impossible to not pin 0.0.1. I raised that 5 years ago: component/trim#7 (comment)

hey @wooorm, I don't quite understand why it's impossible to not pin that dependency. I think I am missing something. Can you elaborate a bit?

@wooorm
Copy link
Member

wooorm commented Sep 27, 2021

https://semver.org/#spec-item-4. Before semver 1.0.0, every change is a breaking change. So updates aren’t pulled in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🙉 open/needs-info This needs some more info 🐛 type/bug This is a problem
Development

No branches or pull requests

4 participants