Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

add configuration option px2rpx #381

Merged
merged 5 commits into from
Nov 19, 2019
Merged

add configuration option px2rpx #381

merged 5 commits into from
Nov 19, 2019

Conversation

Clarence-pan
Copy link
Contributor

fixed #380

@yesmeck
Copy link
Member

yesmeck commented Nov 19, 2019

设置下 git 的 email 信息吧

yesmeck
yesmeck reviewed Nov 19, 2019
View reviewed changes
packages/remax-cli/src/build/rollupConfig.ts Outdated
@@ -67,6 +67,7 @@ export default function rollupConfig(
NODE_ENV: process.env.NODE_ENV || 'development',
REMAX_PLATFORM: argv.target,
REMAX_DEBUG: process.env.REMAX_DEBUG,
REMAX_PX2RPX: `${options.px2Rpx}`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个没必要吧？

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

奥。。是为了 runtime 也能读到。。想想有没有别的办法

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯，要有更好的办法就好了

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 19, 2019 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 831ee8a:

Sandbox Source
magical-yonath-whm8c Configuration

yesmeck
yesmeck reviewed Nov 19, 2019
View reviewed changes
packages/remax-cli/src/defaultOptions.ts Outdated
@@ -2,6 +2,7 @@ import { RemaxOptions } from './getConfig';

const defaultOptions: RemaxOptions = {
cssModules: /\.module\.(less|scss|css)$/,
px2Rpx: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
px2Rpx: true,
pxToRpx: true,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yesmeck 已修改为 pxToRpx, 见 commit#1b88756

@codecov
Copy link

codecov bot commented Nov 19, 2019 •
edited
Loading

Codecov Report

Merging #381 into master will increase coverage by 0.09%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   92.39%   92.49%   +0.09%     
==========================================
  Files         182      183       +1     
  Lines        2631     2638       +7     
  Branches      323      327       +4     
==========================================
+ Hits         2431     2440       +9     
+ Misses        199      197       -2     
  Partials        1        1
Impacted Files Coverage Δ
packages/remax-cli/src/getConfig.ts 100% <ø> (ø) ⬆️
packages/remax-cli/src/defaultOptions.ts 100% <ø> (ø) ⬆️
packages/remax/src/utils/plainStyle.ts 100% <100%> (ø) ⬆️
packages/remax/src/RuntimeOptions.ts 100% <100%> (ø)
packages/remax/src/propsAlias.ts 100% <100%> (ø) ⬆️
packages/remax-cli/src/build/rollupConfig.ts 98.75% <100%> (+2.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ac12f0...831ee8a. Read the comment docs.

@Clarence-pan
Copy link
Contributor Author

设置下 git 的 email 信息吧

好的

@Clarence-pan Clarence-pan force-pushed the feature/config-option-px2Rpx branch from 8ecfc6a to ccd8aa4 Compare November 19, 2019 07:29
Clarence-pan added a commit to Clarence-pan/remax that referenced this pull request Nov 19, 2019
@Clarence-pan
fix(remax): according to review opinions, rename px2Rpx to pxToRpx
1b88756 
re remaxjs#381
@yesmeck
Copy link
Member

yesmeck commented Nov 19, 2019

文档也补一下吧

Clarence-pan added a commit to Clarence-pan/remax that referenced this pull request Nov 19, 2019
@Clarence-pan
docs(remax): add documents about pxToRpx
eea3074 
re remaxjs#381
@Clarence-pan
Copy link
Contributor Author

文档也补一下吧

好的，已补充

@yesmeck
Copy link
Member

yesmeck commented Nov 19, 2019

@Clarence-pan 刚合了几个 PR，需要 rebase 下 master 更新下测试的 snapshot 了。其他没问题了。

@Clarence-pan Clarence-pan force-pushed the feature/config-option-px2Rpx branch from eea3074 to 831ee8a Compare November 19, 2019 08:06
@Clarence-pan
Copy link
Contributor Author

@Clarence-pan 刚合了几个 PR，需要 rebase 下 master 更新下测试的 snapshot 了。其他没问题了。

好的，已修复

@yesmeck yesmeck merged commit dd73e13 into remaxjs:master Nov 19, 2019
@Clarence-pan Clarence-pan deleted the feature/config-option-px2Rpx branch November 19, 2019 08:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yesmeck yesmeck yesmeck left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@Clarence-pan @yesmeck