Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

fix: 修正 App 组件被 HOC 包裹后无法触发生命周期回调的问题 #398

Merged
merged 1 commit into from
Nov 22, 2019

Conversation

yesmeck
Copy link
Member

@yesmeck yesmeck commented Nov 22, 2019

No description provided.

@Darmody
Copy link
Contributor

Darmody commented Nov 22, 2019

LGTM

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 22, 2019

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 8f92253:

Sandbox Source
romantic-faraday-eq82v Configuration

@yesmeck
Copy link
Member Author

yesmeck commented Nov 22, 2019

等我补个测试

@codecov
Copy link

codecov bot commented Nov 22, 2019

Codecov Report

Merging #398 into master will increase coverage by 0.13%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
+ Coverage   93.44%   93.58%   +0.13%     
==========================================
  Files         226      226              
  Lines        2899     2899              
  Branches      335      335              
==========================================
+ Hits         2709     2713       +4     
+ Misses        188      184       -4     
  Partials        2        2
Impacted Files Coverage Δ
packages/remax/src/createAppConfig.ts 56.52% <21.42%> (+6.52%) ⬆️
packages/remax/src/utils/isClass.ts 90.9% <0%> (+9.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e12c04...8f92253. Read the comment docs.

@yesmeck yesmeck merged commit 98be559 into master Nov 22, 2019
@yesmeck yesmeck deleted the fix-app-ref branch November 22, 2019 07:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants