Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"workspaces" key is being shipped in the released npm module package.json #197

Closed
mistic opened this issue Feb 8, 2023 · 3 comments
Closed

Comments

@mistic
Copy link

mistic commented Feb 8, 2023

Currently the package.json being shipped with the node_module contains a workspaces key that is a development artifact only.

This is causing yarn to display a warning during install warning Workspaces can only be enabled in private projects. and should be removed.

@remcohaszing
Copy link
Owner

This is a bug in yarn, not this package.

@remcohaszing remcohaszing closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2023
@mistic
Copy link
Author

mistic commented Feb 8, 2023

@remcohaszing why do you think it is a bug in yarn? There is a long discussion happening at yarnpkg/yarn#8580 about this and no conclusion was made. It looks like yarn is on purpose emitting this warning as the workspaces key is intended for develop only environments or private repositories.

Can't we just extend the release pipeline to quickly change the package.json removing this workspaces key?

@remcohaszing
Copy link
Owner

Yarn is showing a warning for something that is in no way harmful / has no negative impact on the user. The yarn team moved on to yarn 2 (I think even 4 by now?). This issue is for yarn 1, which is no longer actively maintained.

I think several comments in the issue you linked describe it in better detail.

I recommend to move on to a newer package manager, like npm 9 / pnpm / a newer yarn version. If you can’t for whatever reason, I know it’s annoying, but it’s just a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants