Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load ./.teamocil file if no file is provided #132

Open
nicklayb opened this issue Jul 24, 2019 · 3 comments
Open

Load ./.teamocil file if no file is provided #132

nicklayb opened this issue Jul 24, 2019 · 3 comments

Comments

@nicklayb
Copy link

Actually, running teamocil without any arguments attempts to open a .yml in the .teamocil folder in home but gives the following error message:

Cannot find a layout at `/Users/nboisvert/.teamocil/.yml

I would suggest trying to load ./.teamocil.yml if no file is provided. We could then commit .teamocil.yml files in our project so everyone in the team can benefit from it and share the same tmux layout, what do you think?

The only issue I see is if users started writing ~/.teamocil/.yml files to have a default layout.

@remi
Copy link
Owner

remi commented Jul 24, 2019

That’s actually a good idea! We’ll need to make sure there’s no security risks though, to make sure running teamocil in a shared directory (eg. a project repository) is safe 😄

@nicklayb Is this something you might be interested on working on?

@remi remi changed the title Feature request: Load ./.teamocil file if no file provided Load ./.teamocil file if no file is provided Jul 24, 2019
@nicklayb
Copy link
Author

Of course I am! Should not bo too hard to implement. What kind of security issue you have in mind that I should be aware of?

@remi
Copy link
Owner

remi commented Jul 24, 2019

Oh, I was thinking about #70 but this is not something we have anyway.

Let’s just make sure there’s no possibility that I commit changes to a shared .teamocil.yml file in a repository and run some malicious code when you clone it and then run teamocil 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants