Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

basename doesn't exist in createBrowserHistory in history v5 #812

Open
vlzuiev opened this issue Jul 2, 2020 · 4 comments
Open

basename doesn't exist in createBrowserHistory in history v5 #812

vlzuiev opened this issue Jul 2, 2020 · 4 comments

Comments

@vlzuiev
Copy link

vlzuiev commented Jul 2, 2020

What is the way around with basename if I'm using the newest version of history lib(5.0.0)

const history = createBrowserHistory({ basename: '/user-instructions' });

@StringEpsilon
Copy link

Seems to be an intentional change. See the v5 pull request #751 and #811.

There is no workaround to my knowledge.

@morsaken
Copy link

morsaken commented Jul 26, 2020

I think it is a necessary option. Must use the oldest version for that.

@vianvio
Copy link

vianvio commented Aug 19, 2020

why not basename ???? it's so useful

@cinnabarcaracal
Copy link

@vlzuiev I've just started using a very hacky workaround, but I have my fingers crossed that there will be a nicer solution for use navigation from sagas/logic outside of components in the future.

#810 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants