Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support window injection to history #848

Closed
Jony-Y opened this issue Dec 3, 2020 · 1 comment
Closed

Support window injection to history #848

Jony-Y opened this issue Dec 3, 2020 · 1 comment

Comments

@Jony-Y
Copy link

Jony-Y commented Dec 3, 2020

Hi, this is a feature request basically, to which Ill be happy to also provide a PR if needed.
I have a need to control the window for my history implementation.
TL;DR - we have a microfrontend architecture working with iframe and reverse proxy.
Each micro fe uses history with react-router-dom
I would like the ability to pass manually the history object so its not defined as now
globalHistory = window.history;
But Allow me to pass any window history I would want (in my case, window.top.history).

Is this a capability that you're considering adding?
Would it be an augmentation that you would be open to?

@Jony-Y
Copy link
Author

Jony-Y commented Dec 3, 2020

NVM, I see that
#624
Has been added in v5. Will upgrade and try

@Jony-Y Jony-Y closed this as completed Dec 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant