Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch QuotaExceededError #75

Merged
merged 2 commits into from
Oct 7, 2015
Merged

Catch QuotaExceededError #75

merged 2 commits into from
Oct 7, 2015

Conversation

iam4x
Copy link
Contributor

@iam4x iam4x commented Sep 30, 2015

fixes #42

@mjackson
Copy link
Member

mjackson commented Oct 1, 2015

Thanks for the PR, @iam4x. I'd like to address both parts of the solution from #42 (comment) in the same PR. Are you up for it?

@iam4x
Copy link
Contributor Author

iam4x commented Oct 5, 2015

Sure, but I'll need to understand the whole library before or some hints ;)

I've pushed the modifications 👍

Speaking too fast, I broke all the tests...

@@ -1,2 +1,3 @@
lib
umd
node_modules
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this and put it in your ~/.gitignore instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This actually didn't get taken out, but I think it's fine to keep - it's part of standard .gitignore for Node per e.g. https://github.com/github/gitignore/blob/master/Node.gitignore. Most other JS projects ignore node_modules, per e.g. https://github.com/rackt/redux/blob/v3.0.4/.gitignore#L3.

Typically I think the user-global .gitignore is better suited for editor configuration rather than anything even slightly project-specific.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing

@mjackson
Copy link
Member

mjackson commented Oct 7, 2015

This looks good. I can merge and take it from here.

mjackson added a commit that referenced this pull request Oct 7, 2015
Catch `QuotaExceededError`
@mjackson mjackson merged commit 64af5ea into remix-run:master Oct 7, 2015
@lock lock bot locked as resolved and limited conversation to collaborators Jun 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

QuotaExceededError in Safari incognito mode
4 participants