-
Notifications
You must be signed in to change notification settings - Fork 961
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Catch QuotaExceededError
#75
Conversation
Thanks for the PR, @iam4x. I'd like to address both parts of the solution from #42 (comment) in the same PR. Are you up for it? |
Sure,
Speaking too fast, I broke all the tests... |
@@ -1,2 +1,3 @@ | |||
lib | |||
umd | |||
node_modules |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove this and put it in your ~/.gitignore
instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This actually didn't get taken out, but I think it's fine to keep - it's part of standard .gitignore
for Node per e.g. https://github.com/github/gitignore/blob/master/Node.gitignore. Most other JS projects ignore node_modules
, per e.g. https://github.com/rackt/redux/blob/v3.0.4/.gitignore#L3.
Typically I think the user-global .gitignore
is better suited for editor configuration rather than anything even slightly project-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
testing
This looks good. I can merge and take it from here. |
fixes #42