From 7dca9dc38c837ed94796325b1e0582aa72a9313f Mon Sep 17 00:00:00 2001 From: "remix-cla-bot[bot]" <92060565+remix-cla-bot[bot]@users.noreply.github.com> Date: Mon, 28 Feb 2022 23:51:27 +0000 Subject: [PATCH 01/10] chore: sort contributors list --- contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 50c3af1672..e1443b0b7e 100644 --- a/contributors.yml +++ b/contributors.yml @@ -25,6 +25,7 @@ - kentcdodds - kkirsche - koojaa +- KutnerUri - latin-1 - liuhanqu - lukerSpringTree @@ -44,4 +45,3 @@ - turansky - underager - vijaypushkin -- KutnerUri From d10d8906e6767d631f15a0183be543ad001167f8 Mon Sep 17 00:00:00 2001 From: mfijas Date: Mon, 14 Mar 2022 16:13:33 +0100 Subject: [PATCH 02/10] Update tutorial.md (#8717) --- contributors.yml | 1 + docs/getting-started/tutorial.md | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/contributors.yml b/contributors.yml index e1443b0b7e..7a4bd77a4b 100644 --- a/contributors.yml +++ b/contributors.yml @@ -45,3 +45,4 @@ - turansky - underager - vijaypushkin +- mfijas diff --git a/docs/getting-started/tutorial.md b/docs/getting-started/tutorial.md index 2929323f5c..047770aa7c 100644 --- a/docs/getting-started/tutorial.md +++ b/docs/getting-started/tutorial.md @@ -172,7 +172,7 @@ export default function Invoices() { Finally, let's teach React Router how to render our app at different URLs by creating our first "Route Config" inside of `main.jsx` or `index.js`. -```tsx lines=[2,4-5,13-19] filename=src/main.jsx +```tsx lines=[2,4-5,8-9,13-19] filename=src/main.jsx import { render } from "react-dom"; import { BrowserRouter, @@ -806,7 +806,7 @@ export function deleteInvoice(number) { Now let's add the delete button, call our new function, and navigate to the index route: -```js lines=[1-2,5-6,17-26] filename=src/routes/invoice.jsx +```js lines=[1-6,20-29] filename=src/routes/invoice.jsx import { useParams, useNavigate, From 86d12b95856f3e22462a15792220258522c720c9 Mon Sep 17 00:00:00 2001 From: "remix-cla-bot[bot]" <92060565+remix-cla-bot[bot]@users.noreply.github.com> Date: Mon, 14 Mar 2022 15:13:52 +0000 Subject: [PATCH 03/10] chore: sort contributors list --- contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 7a4bd77a4b..47ea0ef0a2 100644 --- a/contributors.yml +++ b/contributors.yml @@ -31,6 +31,7 @@ - lukerSpringTree - markivancho - mcansh +- mfijas - noisypigeon - paulsmithkc - petersendidit @@ -45,4 +46,3 @@ - turansky - underager - vijaypushkin -- mfijas From 3ccfe53dbf943df77dab6a70d482ae244be79437 Mon Sep 17 00:00:00 2001 From: ThornWu Date: Wed, 16 Mar 2022 04:50:51 +0800 Subject: [PATCH 04/10] docs: fix the usage of history.listen (#8718) --- contributors.yml | 1 + docs/getting-started/concepts.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 47ea0ef0a2..56fa79b53f 100644 --- a/contributors.yml +++ b/contributors.yml @@ -46,3 +46,4 @@ - turansky - underager - vijaypushkin +- ThornWu diff --git a/docs/getting-started/concepts.md b/docs/getting-started/concepts.md index 5b810304d9..aa765916ad 100644 --- a/docs/getting-started/concepts.md +++ b/docs/getting-started/concepts.md @@ -127,7 +127,7 @@ That's where a React Router specific `history` object comes into play. It provid ```js let history = createBrowserHistory(); -history.listen((location, action) => { +history.listen(({location, action}) => { // this is called whenever new locations come in // the action is POP, PUSH, or REPLACE }); From c8dff1b7141bf908c16f73cdbade18fdd9c59188 Mon Sep 17 00:00:00 2001 From: "remix-cla-bot[bot]" <92060565+remix-cla-bot[bot]@users.noreply.github.com> Date: Tue, 15 Mar 2022 20:51:13 +0000 Subject: [PATCH 05/10] chore: sort contributors list --- contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 56fa79b53f..dc8dcf07cf 100644 --- a/contributors.yml +++ b/contributors.yml @@ -42,8 +42,8 @@ - shihanng - shivamsinghchahar - thisiskartik +- ThornWu - timdorr - turansky - underager - vijaypushkin -- ThornWu From e3fdf193b01c640ad17680783c3fc91e0472f290 Mon Sep 17 00:00:00 2001 From: Jan Paepke Date: Tue, 15 Mar 2022 21:51:25 +0100 Subject: [PATCH 06/10] fixed small typo (#8651) --- contributors.yml | 1 + docs/getting-started/concepts.md | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index dc8dcf07cf..7b11e7f67d 100644 --- a/contributors.yml +++ b/contributors.yml @@ -47,3 +47,4 @@ - turansky - underager - vijaypushkin +- janpaepke \ No newline at end of file diff --git a/docs/getting-started/concepts.md b/docs/getting-started/concepts.md index aa765916ad..411136bdf5 100644 --- a/docs/getting-started/concepts.md +++ b/docs/getting-started/concepts.md @@ -668,7 +668,7 @@ The `PageLayout` route is admittedly weird. We call it a [layout route](#layout- ```jsx bad lines=[14-16,22-24] - }> + }> } /> }> } /> From 9f831bf86d00bdc4b17494dba6371a8354f1ad54 Mon Sep 17 00:00:00 2001 From: "remix-cla-bot[bot]" <92060565+remix-cla-bot[bot]@users.noreply.github.com> Date: Tue, 15 Mar 2022 20:51:31 +0000 Subject: [PATCH 07/10] chore: sort contributors list --- contributors.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contributors.yml b/contributors.yml index 7b11e7f67d..982ef838a5 100644 --- a/contributors.yml +++ b/contributors.yml @@ -18,6 +18,7 @@ - IbraRouisDev - Isammoc - JakubDrozd +- janpaepke - jmargeta - jonkoops - kantuni @@ -47,4 +48,3 @@ - turansky - underager - vijaypushkin -- janpaepke \ No newline at end of file From 82adc1601039a87e2f925690cb949ce85a766150 Mon Sep 17 00:00:00 2001 From: Remix Run Bot Date: Tue, 15 Mar 2022 20:52:45 +0000 Subject: [PATCH 08/10] chore: format --- docs/getting-started/concepts.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/getting-started/concepts.md b/docs/getting-started/concepts.md index 411136bdf5..f48bd4c023 100644 --- a/docs/getting-started/concepts.md +++ b/docs/getting-started/concepts.md @@ -127,7 +127,7 @@ That's where a React Router specific `history` object comes into play. It provid ```js let history = createBrowserHistory(); -history.listen(({location, action}) => { +history.listen(({ location, action }) => { // this is called whenever new locations come in // the action is POP, PUSH, or REPLACE }); From c299d29c7eeb1b3fc3c1726a5d6ebebdfb74ea4a Mon Sep 17 00:00:00 2001 From: Tim Dorr Date: Wed, 16 Mar 2022 22:13:41 -0400 Subject: [PATCH 09/10] Update issue links --- .github/ISSUE_TEMPLATE/bug_report.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/bug_report.yml b/.github/ISSUE_TEMPLATE/bug_report.yml index 34605e26b8..6e8038e3cb 100644 --- a/.github/ISSUE_TEMPLATE/bug_report.yml +++ b/.github/ISSUE_TEMPLATE/bug_report.yml @@ -16,9 +16,9 @@ body: you ask a question, here are some resources to get help first: - Read the docs: https://reactrouter.com - - Check out the list of frequently asked questions: https://reactrouter.com/docs/en/v6/getting-started/faq + - Check out the list of frequently asked questions: https://reactrouter.com/docs/en/v6/faq - Explore examples: https://reactrouter.com/docs/en/v6/examples/basic - - Look for/ask questions on Stack Overflow: https://stackoverflow.com/questions/ask?tags=react-router + - Look for/ask questions on Stack Overflow: https://stackoverflow.com/questions/tagged/react-router - Ask in chat: https://discord.gg/6RyV8n8yyM ### Test Case Starter: From 43ef25a4b12a13b5920480cebda8a46c45c933ec Mon Sep 17 00:00:00 2001 From: Tim Dorr Date: Wed, 16 Mar 2022 22:14:12 -0400 Subject: [PATCH 10/10] Update issue links --- .github/ISSUE_TEMPLATE/feature_request.yml | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/feature_request.yml b/.github/ISSUE_TEMPLATE/feature_request.yml index f1a9ef9675..4985b2f072 100644 --- a/.github/ISSUE_TEMPLATE/feature_request.yml +++ b/.github/ISSUE_TEMPLATE/feature_request.yml @@ -16,9 +16,9 @@ body: you ask a question, here are some resources to get help first: - Read the docs: https://reactrouter.com - - Check out the list of frequently asked questions: https://reactrouter.com/docs/en/v6/getting-started/faq - - Explore examples: hhttps://reactrouter.com/docs/en/v6/examples/basic - - Look for/ask questions on Stack Overflow: https://stackoverflow.com/questions/ask?tags=react-router + - Check out the list of frequently asked questions: https://reactrouter.com/docs/en/v6/faq + - Explore examples: https://reactrouter.com/docs/en/v6/examples/basic + - Look for/ask questions on Stack Overflow: https://stackoverflow.com/questions/tagged/react-router - Ask in chat: https://discord.gg/6RyV8n8yyM - type: textarea attributes: