-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isActive should not be on history #2606
Comments
If we have a concept of a "routing location" that supports |
I'd like to keep location objects as simple as possible (i.e. not add a bunch of methods that make them impossible to serialize). Also, the current design of location objects is analogous to |
Fair enough there - the issue is more that it's on |
I agree it's a bit messy. |
I'm re-opening this, then. |
Route matching is a property of the |
Fold this into #2614 as well. |
It'd be a cleaner API - lets us keep the API to
history
stateless, and "active" state does belong naturally to the location object.The text was updated successfully, but these errors were encountered: