Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document the gotcha for esbuild css plugin #4396

Closed
machour opened this issue Oct 20, 2022 · 3 comments
Closed

Document the gotcha for esbuild css plugin #4396

machour opened this issue Oct 20, 2022 · 3 comments
Labels

Comments

@machour
Copy link
Collaborator

machour commented Oct 20, 2022

An error is thrown when using either filter for onLoad (seems like esbuild is attempting to load it as js even though "main" is pointed to index.css)

We need to document a little gotcha until we find a proper solution, see discussion here: #4130 (comment)

@machour machour added the docs label Oct 20, 2022
@KingSora
Copy link
Contributor

@machour I think it would be good if we investigate further on this, because isolated tests show that this issue might be related to other plugins / things above esbuild. Opened an issue on esbuilds side and got the confirmation there as well. #4130 (comment)

@machour
Copy link
Collaborator Author

machour commented Oct 20, 2022

Definitely, but until then, the issue should be properly documented for our users.

Thank you again for your contribution, already using it! 🙏

@machour
Copy link
Collaborator Author

machour commented Jan 22, 2023

Nobody complained 🤷🏼

@machour machour closed this as not planned Won't fix, can't repro, duplicate, stale Jan 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants