Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

404 Page Causes Infinite Reload After Using npx create-remix@latest #9821

Closed
y0tik opened this issue Aug 3, 2024 · 9 comments
Closed

404 Page Causes Infinite Reload After Using npx create-remix@latest #9821

y0tik opened this issue Aug 3, 2024 · 9 comments

Comments

@y0tik
Copy link

y0tik commented Aug 3, 2024

Reproduction

  1. Install the latest version using one of the following methods:

  2. Start the development server

  3. Navigate to http://localhost:5173/404 or any other non-existent page

System Info

System:
    OS: Linux 5.15 Arch Linux
    CPU: (16) x64 12th Gen Intel(R) Core(TM) i5-12500H
    Memory: 6.89 GB / 7.61 GB
    Container: Yes
    Shell: 3.7.1 - /bin/fish
  Binaries:
    Node: 20.14.0 - ~/.local/share/nvm/v20.14.0/bin/node
    npm: 10.7.0 - ~/.local/share/nvm/v20.14.0/bin/npm
    pnpm: 9.3.0 - ~/.local/share/pnpm/pnpm

Used Package Manager

pnpm

Expected Behavior

When visiting a 404 page, display the nearest or the root ErrorBoundary without causing an infinite reload

Actual Behavior

Infinity page reload when visiting a 404 page, both in development and in production

@rossipedia
Copy link
Contributor

FWIW I cannot reproduce this using v2.10.3, but I can with v2.11.0

@austinjherman
Copy link

I noticed the same issue. Also using v2.11.0.

@bravo-kernel
Copy link
Contributor

bravo-kernel commented Aug 4, 2024

My codebase has the same issue:

  • Infinite 404 loop with both remix 2.10.3 and 2.11.0
  • The loop goes away when I disable <Scripts /> component in my layout

@Arichy
Copy link

Arichy commented Aug 4, 2024

Same here, but infinite reload for all paths
image

After downgrading @remix-run/serve from 2.11.0 to 2.10.3, it's fixed. Look like something is wrong in latest version.
image

@alcpereira
Copy link
Contributor

alcpereira commented Aug 4, 2024

To help narrow down the issue: only happens in 2.11.0

@ironheart122
Copy link

Yep, can confirm I ran into this very issue today. I had to downgrade to 2.10.x which doesn't have this bug.

@ngbrown
Copy link
Contributor

ngbrown commented Aug 5, 2024

It also happens on production servers built and deployed to Cloudflare.

I seemed to have fixed it with a one-line patch. See my comment here: #9695 (comment)

@machour
Copy link
Collaborator

machour commented Aug 8, 2024

This should be fixed by v2.11.1.
Could you all confirm? 🙏🏼

@petrpacas
Copy link
Contributor

Fixed for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests