fix: specify esbuild target #4704
Conversation
|
|
I don't think this PR will make it as it is, I know the team have been thinking about having a browserlist setting. |
| @@ -82,6 +82,7 @@ const createEsbuildConfig = ( | |||
| entryPoints, | |||
| outdir: config.assetsBuildDirectory, | |||
| platform: "browser", | |||
| target: ['safari12'], | |||
There was a problem hiding this comment.
If the goal is to support safari as documented, this should be safari11 as that's the first version to support ES modules
I created a ticket for this #4762
There was a problem hiding this comment.
the reason I pick safari12 is because this error message
✘ [ERROR] Transforming async generator functions to the configured target environment ("safari11" + 1 override) is not supported yet
node_modules/.pnpm/@web3-storage+multipart-parser@1.0.0/node_modules/@web3-storage/multipart-parser/esm/src/search.js:253:0:
253 │ async function* arrayIterator(iter) {
╵ ~~~~~
There was a problem hiding this comment.
@lili21 yeah, I ran into this as well. Thanks for posting this, it finally got me add a comment I've been meaning to make for months
MichaelDeBoey
force-pushed
the
esbuild-target
branch
from
d3985c0 to
7689f12
Compare
|
Closing this out in favor of #4769 |
Remix should work in browsers that support ES Modules. But Remix doesn't handle some new syntax which break the statement.
fix #1901