Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move ColorScheme inside Ansi class #102

Closed
remkop opened this issue Apr 18, 2017 · 1 comment
Closed

Move ColorScheme inside Ansi class #102

remkop opened this issue Apr 18, 2017 · 1 comment
Labels
status: declined ❌ A suggestion or change that we don't feel we should currently apply type: enhancement ✨ type: question ❔
Milestone
0.9.1 bugfixes

Comments

@remkop
Copy link
Owner

remkop commented Apr 18, 2017 •
edited

No description provided.

@remkop remkop added this to the 0.9.1 bugfixes milestone Apr 18, 2017
@remkop remkop added the status: declined ❌ A suggestion or change that we don't feel we should currently apply label Apr 18, 2017
@remkop
Copy link
Owner Author

remkop commented Apr 18, 2017

Won't fix this. CommandLine.Help.ColorScheme is used in some top level API methods and the type is long enough as it is.

CommandLine.Help.Ansi.ColorScheme is slightly more consistent, but CommandLine.Help.ColorScheme is not confusing so the increased consistency is not worth the overly verbose type name in the top level API.

@remkop remkop closed this as completed Apr 18, 2017
@remkop remkop mentioned this issue May 9, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: declined ❌ A suggestion or change that we don't feel we should currently apply type: enhancement ✨ type: question ❔
Projects
None yet
Milestone
0.9.1 bugfixes
Development

No branches or pull requests
1 participant
@remkop