Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEP: Remove dependency on slf4j from picocli-spring-boot-starter #1604

Closed
remkop opened this issue Feb 25, 2022 · 0 comments
Closed

DEP: Remove dependency on slf4j from picocli-spring-boot-starter #1604

remkop opened this issue Feb 25, 2022 · 0 comments

Comments

@remkop
Copy link
Owner

remkop commented Feb 25, 2022

Use java.util.logging instead of slf4j library for logging in picocli-spring-boot-starter.

TBD: This allows us to replace requires org.slf4j in module-info with requires java.util.logging.
The idea is to only require modules spring.boot and spring.boot.autoconfigure instead of spring.boot.starter in our module-info.

(Note: ✏️ if spring.boot.starter is needed on the module-path when generating modular javadoc anyway, then there is no point in doing this and this idea can be dropped. 🤷 )

Applications that want to use slf4j can simply add dependency org.slf4j:jul-to-slf4j.

Applications that have a dependency on spring-boot-starter, or otherwise have a dependency on spring-boot-starter-logging already include dependency org.slf4j:jul-to-slf4j, so they should have no impact.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant