Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change picocli-spring-boot-starter JPMS module name to info.picocli.spring.boot from info.picocli.spring #1614

Closed
remkop opened this issue Feb 27, 2022 · 0 comments
Labels
theme: compatibility Issues related to binary and source backwards compatibility theme: module An issue or change related to JPMS modules type: API 🔌
Milestone

Comments

@remkop
Copy link
Owner

remkop commented Feb 27, 2022

Related to #1608:

Change picocli-spring-boot-starter JPMS module name to info.picocli.spring.boot from info.picocli.spring.

Now that picocli-spring-boot-starter is an explicitly declared JPMS module, I noticed the inconsistent naming compared to the names of the Spring Boot dependencies themselves.

I believe info.picocli.spring.boot is a better name, and timing-wise, making this change while converting from Automatic modules to explicitly declared modules seems like a good time to make this change.

@remkop remkop added this to the 4.7 milestone Feb 27, 2022
@remkop remkop added theme: compatibility Issues related to binary and source backwards compatibility theme: module An issue or change related to JPMS modules type: API 🔌 labels Feb 27, 2022
@remkop remkop closed this as completed in 8e21b71 Feb 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
theme: compatibility Issues related to binary and source backwards compatibility theme: module An issue or change related to JPMS modules type: API 🔌
Projects
None yet
Development

No branches or pull requests

1 participant