Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

showDefaultValues = true prints null as default value #201

Closed
jansohn opened this issue Oct 10, 2017 · 3 comments
Closed

showDefaultValues = true prints null as default value #201

jansohn opened this issue Oct 10, 2017 · 3 comments

Comments

@jansohn
Copy link

jansohn commented Oct 10, 2017

I wasn't expecting member variables initialized with null (mostly Strings...) to be displayed with Default: null after activating showDefaultValues = true. Is there a possibility to only display not null default values?

@remkop
Copy link
Owner

remkop commented Oct 13, 2017

Thanks for raising this!
The fix has been pushed to master. Please verify.

@jansohn
Copy link
Author

jansohn commented Oct 13, 2017

Thanks for fixing this. I can confirm that it works. Is there any particular reason that the default values are being printed on a new line? I'm more familiar with the default values being displayed on the same line as the description (e.g. http://docopt.org/).

@remkop
Copy link
Owner

remkop commented Oct 14, 2017

Putting the default value on a new line looks reasonably good even if the last description sentence does not end in a period. The docopt way also looks good though.

Could consider making this configurable but I need to think about how to do that without overcomplicating things.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants