Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prefix ParseResult methods with matched if they return only matched options/positionals #342

Closed
remkop opened this issue Apr 9, 2018 · 0 comments
Closed

Prefix ParseResult methods with matched if they return only matched options/positionals #342

remkop opened this issue Apr 9, 2018 · 0 comments
Labels
type: API 🔌 type: enhancement ✨
Milestone
3.0

Comments

@remkop
Copy link
Owner

remkop commented Apr 9, 2018

Currently methods are named

  • options
  • positionals
  • option(char), option(String)
  • positional(int)
  • hasOption(char), hasOption(String), hasOption(OptionSpec)
  • hasPositional(int), hasPositional(PositionalParamSpec)

These should all be prefixed with matched, so matchedOptions, hasMatchedOption etc.
This helps to clarify the semantics of #340 and #341 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: API 🔌 type: enhancement ✨
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@remkop