Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interpreter should call ArgSpec.setValue for every matched option or positional parameter #348

Closed
remkop opened this issue Apr 10, 2018 · 0 comments

Comments

@remkop
Copy link
Owner

remkop commented Apr 10, 2018

Currently it only calls setValue for single-value options and for array options.
For Collections and Maps, the interpreter only calls the getter and then adds values to the returned mutable data structure.

To provide a consistent protocol for custom bindings, it is better to always call the setter when the value of an option or positional parameter is modified.

@remkop remkop added this to the 3.0 milestone Apr 10, 2018
@remkop remkop closed this as completed in f5326f4 Apr 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant