Approximate istty() by checking System.console() != null

[remkop]

Use reflection to avoid introducing dependency on Java 6.

As indicated here, this is not entirely correct, but still better than no check at all...

[remkop]

            static final boolean ISATTY = calcTTY();
            static final boolean calcTTY() {
                try { return System.class.getDeclaredMethod("console").invoke(null) != null; }
                catch (Throwable reflectionFailed) {return true;}
            }

            private static boolean ansiPossible() { return ISATTY && (!isWindows || isXterm); }

[bric3]

Hi,

It seems that in JDK 22, checking is System.console() returning null might not be enough. With JDK 22 there is now a Console::isTerminal as the new default console is based on JLine.

• https://bugs.openjdk.org/browse/JDK-8309155
• openjdk/jdk@bae2247

It still doesn't allow to be specific about which side is interactive or not though.

[remkop]

Hi,

It seems that in JDK 22, checking is System.console() returning null might not be enough. With JDK 22 there is now a Console::isTerminal as the new default console is based on JLine.

• https://bugs.openjdk.org/browse/JDK-8309155
• openjdk/jdk@bae2247

It still doesn't allow to be specific about which side is interactive or not though.

@bric3 Please refer to #1104, #2083 and #2084 ; is there still an issue?

[bric3]

Oh thank you @remkop I wasn't looking for these keyword so I didn't find them.

No issue I was just exploring available options to detect if stdin or stdout were interactive (e.g. when piping). And I stumbled on this PR so I made the comment, but I'm way late as other work has been done.