Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Audio does not get removed if switching from 1 component to another #2033

Closed
JonnyBurger opened this issue Apr 19, 2023 · 2 comments · Fixed by #2117
Closed

Audio does not get removed if switching from 1 component to another #2033

JonnyBurger opened this issue Apr 19, 2023 · 2 comments · Fixed by #2117
Labels
bug Something isn't working

Comments

@JonnyBurger
Copy link
Member

remotion-poc.vercel.app
https://github.com/santoshgistto/remotion-poc

I actually claim that this is an upstream React bug: facebook/react#26670
@JonnyBurger JonnyBurger added the bug Something isn't working label Apr 19, 2023
@JonnyBurger JonnyBurger mentioned this issue Apr 19, 2023
Closed
@JonnyBurger JonnyBurger linked a pull request Apr 19, 2023 that will close this issue
Reset shared audio tags when switching the composition #2117
Merged
@JonnyBurger
Copy link
Member Author

I found a fix for it, will ship this in the next release for you to test.

Regarding the other bug, let's see separately!

@santoshgistto
Copy link

Sure thank you @JonnyBurger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Reset shared audio tags when switching the composition remotion-dev/remotion
2 participants
@JonnyBurger @santoshgistto