-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
How to migrate from this gem to the rails 7 setup? #132
Comments
I'm looking to get this working with I would love to know as well. Looking into it and will leave a comment once I find a good answer. |
This gem is tied to Webpacker, and I think I will deprecate it as well following Webpacker's deprecation. To replace Webpacker, you can either:
Then you need to replace
I am wondering if this project can be easily converted to no longer rely on Webpacker at all, I will try to have a look at it but no promises! |
I'm using this gem without webpacker (but without HSM). I'm using jsbundling-rails with esbuild on rails 7.0.1, ruby 3.0.2 I only have to add lodash as dependency in package.json (perhaps it can be added as dependency to this module) Perhaps this module should be renamed to suppress the reference to webpacker. |
I made some tests and this gem indeed does not need Webpacker at all. I am a bit busy right now, but I will try find find time to:
|
I upgraded rails7 from rails 6, that choise propshaft, jsbuilding-rails. When I was using rails6, I used webpacker-react, but I didn't choose webpack, so I don't use it now.
This file is almost equivalent to this one. |
I was going to make a gem with the above modified component, but I thought it would be better to decide this issue here, so I decided not to. Since react is an inseparable part of my project, I will maintain this. |
Seems OK for me |
Thanks @yubele for the name suggestion, you are right, lets make it simple :) I started a PR which renames this library and adopt a more modern JS build system rather that the current monster I created. |
Hey all, I've been out for a while, but thanks so much for the help and the kind responses. If there is some way I could help to move this to the finish line I've be more than happy to do so. |
just a remark. Actually this gem require webacker in webpacker-react.gemspec:
So bundler add this gem to the list of needed gem. As this is not needed, we can suppress it and reduce the size of the bundle. It would be nice to release a latest version of this gem without this requirement as it is not needed. |
As said above, I am working on a new version of this gem, with a new name and a much simpler setup. You can see the work in progress in this PR: #139 This new version will no longer depend on Webpacker (or Webpack). |
React 18 is out ( https://reactjs.org/blog/2022/03/08/react-18-upgrade-guide.html) and change the rendering methods. Perhaps it would be needed to test "React.version" to use the correct way (< React 18 or >= React 18) of rendering |
The new beta 4 work as expected for my use. |
could we have a new stable release ? |
Hey
Since webpacker is being deprecated on Rails 7. I was wondering how could we migrate an app that uses this gem to the new rails 7 Esbuild/Webpack Setup.
Any help would be very much appreciated
The text was updated successfully, but these errors were encountered: