Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed meaning of ./= in Julia 0.5 #2

Closed
stevengj opened this issue Jul 22, 2016 · 0 comments
Closed

Changed meaning of ./= in Julia 0.5 #2

stevengj opened this issue Jul 22, 2016 · 0 comments

Comments

@stevengj
Copy link

Your test code uses x ./= y, so you should know that in Julia 0.5 this has changed meaning to be equivalent to broadcast!(identity, x, x ./ y), so that it mutates the x array (see JuliaLang/julia#17510 … in Julia 0.6 the whole operation will occur in-place without temporaries). So ./ should only be used if the left-hand side is a mutable array, and you don't mind mutating it.

At first glance, this looks like the new behavior is okay for you, because it looks like you use ./= to mutate array slices. However, I noticed what looks like a bug: your code has aligned[:,:,1] = aligned[:,:,1] ./= relativescales[1], which has a redundant assignment. I think you meant just aligned[:,:,1] ./= relativescales[1].

Note, however, that there is currently a bug in Julia 0.5, and aligned[:,:,1] ./= .*= ... won't work correctly until JuliaLang/julia#17546 is merged. (Until then, you can use aligned[:,:,1] = aligned[:,:,1] ./ relativescales[1])

@rened rened closed this as completed Aug 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants