Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add github enterprise example #732

Merged
merged 3 commits into from
May 22, 2023
Merged

docs: add github enterprise example #732

merged 3 commits into from
May 22, 2023

Conversation

dominik-ba
Copy link
Contributor

No description provided.

@viceice viceice changed the title add github enterprise example docs: add github enterprise example May 3, 2023
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see much benefit for this 🤔

@dominik-ba
Copy link
Contributor Author

if one wants to use this action on an enterprise instance one gets only abstract error messages about authentication. So a very small hint in the readme can help others from spending too much time on research why it fails ;)

I don't see much benefit for this 🤔

The very important point to your comment would be: Is there a disadvantage to enhancing docs?

@viceice viceice requested review from rarkins and jdbruijn May 12, 2023 08:21
Copy link
Collaborator

@jdbruijn jdbruijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Indeed very similar to the existing example. THB, I have no strong opinion on whether or not to include it.

@dominik-ba
Copy link
Contributor Author

Indeed very similar to the existing example. THB, I have no strong opinion on whether or not to include it.

It's not about the similarity but the important addition of the GitHub Enterprise url. It takes quite some time to find the important information how to configure this. I would expect something like this in the docs easily to find...

@rarkins rarkins enabled auto-merge (squash) May 22, 2023 06:47
@rarkins rarkins merged commit 03f0628 into renovatebot:main May 22, 2023
@dominik-ba dominik-ba deleted the patch-1 branch May 22, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants