-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: allow to override docker command and user #783
Conversation
Add an option to specify a docker command and a docker user. It is useful if you need to customize your image before running `renovate`. It maybe a partial option for renovatebot/renovate#8804 The idea start from this discussion renovatebot/renovate#23500
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't like it, but ok
please add an e2e test |
I added a test (actually modifying the existing one to use the new feature). You say "you don't like it" :-), happy to hear your thought about it, it was a way to solve my own problem but if you see a better solution let me know |
hey @viceice just a quick heads up |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@viceice sorry for the delay, I was off 🌴 |
@viceice 👋 ;-) |
README.md
Outdated
- [`docker-cmd-file`](#docker-cmd-file) | ||
- [`docker-user`](#docker-user) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should sort aphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Hey @viceice, any chance to have this merged & released? |
use the re-request review button |
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Add an option to specify a docker command and a docker user.
It is useful if you need to customize your image before running
renovate
.It maybe a partial option for
renovatebot/renovate#8804
The idea start from this discussion
renovatebot/renovate#23500