Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace @tsconfig/node14 with @tsconfig/node18 and @tsconfig/strictest #270

Merged
merged 1 commit into from
Apr 1, 2023

Conversation

JamieMagee
Copy link
Contributor

No description provided.

@JamieMagee JamieMagee requested a review from viceice March 27, 2023 00:30
@JamieMagee JamieMagee force-pushed the chore/tsconfig branch 2 times, most recently from 2f3018b to e176526 Compare March 28, 2023 03:42
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eslint has problems using the array extends syntax, we should stay at string for now?

@JamieMagee
Copy link
Contributor Author

eslint has problems using the array extends syntax, we should stay at string for now?

This isn't an issue according to eslint's Typescript 5.0 support issue

Other changes with no impact to us

  • Supporting Multiple Configuration Files in extends

@JamieMagee JamieMagee enabled auto-merge (squash) April 1, 2023 02:44
@viceice
Copy link
Member

viceice commented Apr 1, 2023

eslint has problems using the array extends syntax, we should stay at string for now?

This isn't an issue according to eslint's Typescript 5.0 support issue

Other changes with no impact to us

  • Supporting Multiple Configuration Files in extends

it was not eslint itself, but a transitive dependency. if I remember correctly it was a tsconfig load package. maybe that is now fixed by newer version.

@JamieMagee JamieMagee merged commit 8e99a29 into main Apr 1, 2023
@JamieMagee JamieMagee deleted the chore/tsconfig branch April 1, 2023 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants