Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove function types #115

Merged
merged 19 commits into from
Jan 10, 2022
Merged

refactor: remove function types #115

merged 19 commits into from
Jan 10, 2022

Conversation

RahulGautamSingh
Copy link
Contributor

@RahulGautamSingh RahulGautamSingh commented Jan 10, 2022

Changes:

Removed all function types like:-
VersionFunctionType
OperatorFunctionType
SemanticFunctionType

Context:

These types are causing issues in strictNullChecks in renovate.

RahulGautamSingh and others added 17 commits January 4, 2022 23:38
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
@rarkins
Copy link
Contributor

rarkins commented Jan 10, 2022

@RahulGautamSingh lots of conflicts here

@RahulGautamSingh
Copy link
Contributor Author

RahulGautamSingh commented Jan 10, 2022

@RahulGautamSingh lots of conflicts here

Should have created a new branch.
Resolved all 🟩

@RahulGautamSingh
Copy link
Contributor Author

@rarkins @viceice Ready for review and merge.🟩

lib/shared.d.ts Show resolved Hide resolved
@viceice viceice merged commit 0054d38 into renovatebot:main Jan 10, 2022
@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RahulGautamSingh RahulGautamSingh deleted the feat/add-type-declarations branch February 19, 2022 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants