Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: export type RANGE_PATTERN #119

Merged
merged 6 commits into from
Jan 11, 2022
Merged

feat: export type RANGE_PATTERN #119

merged 6 commits into from
Jan 11, 2022

Conversation

RahulGautamSingh
Copy link
Contributor

Changes:

  • Export type RANGE_PATTERN from index.d.ts

Context:

viceice
viceice reviewed Jan 11, 2022
View reviewed changes
Copy link
Member

@viceice viceice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs also be exported from index js.

Can you check renovate for other deep pep440 imports? We should export all required values from index.js

index.d.ts Outdated Show resolved Hide resolved
@viceice viceice changed the title refactor: export type RANGE_PATTERN feat: export type RANGE_PATTERN Jan 11, 2022
viceice
viceice reviewed Jan 11, 2022
View reviewed changes
index.d.ts Outdated Show resolved Hide resolved
@viceice viceice merged commit 5ce4829 into renovatebot:main Jan 11, 2022
@RahulGautamSingh
Copy link
Contributor Author

This needs also be exported from index js.

Can you check renovate for other deep pep440 imports? We should export all required values from index.js

We use RANGE_PATTERN in lib/manager/(pip_requirements/pip_setup/pipenv)/extract.ts.
The updates we have made should handle those.

@viceice
Copy link
Member

viceice commented Jan 11, 2022

Yes, but i like to remove all deep imports after update, that will simplify all code. it's somehow related to make an esm version of renovate

@github-actions
Copy link

🎉 This PR is included in version 1.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@RahulGautamSingh RahulGautamSingh deleted the refactor/export-const-range-pattern branch February 19, 2022 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viceice viceice viceice approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RahulGautamSingh @viceice