Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove xregexp and use build-in RegExp #121

Closed
viceice opened this issue Jan 11, 2022 · 2 comments
Closed

Remove xregexp and use build-in RegExp #121

viceice opened this issue Jan 11, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@viceice
Copy link
Member

viceice commented Jan 11, 2022 •
edited
Loading

What would you like to be able to do?

We should remove xregexp dependency, as there is no used benefit. We can maybe use RE2?

It looks like xregexp was added in old node v10 ages and is no longer required.

Did you already have any implementation ideas?

yes, simply use normal RegExp class.

/cc @RahulGautamSingh
@viceice viceice added the enhancement New feature or request label Jan 11, 2022
@viceice
Copy link
Member Author

viceice commented Jan 11, 2022

@rarkins WDYT?

@viceice
Copy link
Member Author

viceice commented Jan 14, 2022

fixed in #137

@viceice viceice closed this as completed Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@viceice