Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: setup pre-commit hook #150

Merged
merged 6 commits into from
Feb 23, 2022
Merged

feat: setup pre-commit hook #150

merged 6 commits into from
Feb 23, 2022

Conversation

RahulGautamSingh
Copy link
Contributor

Changes:

  • Setup pre-commit hook using husky

Context:

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@rarkins rarkins merged commit 5b874d6 into renovatebot:main Feb 23, 2022
@rarkins
Copy link
Contributor

rarkins commented Feb 23, 2022

D'oh. This should have been a chore: not feat:

@RahulGautamSingh
Copy link
Contributor Author

D'oh. This should have been a chore: not feat:

Will be careful next time.

@viceice
Copy link
Member

viceice commented Feb 24, 2022

@RahulGautamSingh this is not a feature 😉 this change now caused unnecessary release bubbling. So next time only mark as feature if it really changes final package. 🤗

@RahulGautamSingh RahulGautamSingh deleted the feat/re-commit-hook branch April 2, 2022 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants