monorepo:sentry-javascript should also include getsentry/sentry-electron #30163
markspolakovs
started this conversation in
Suggest an Idea
Replies: 1 comment
-
The downside is that if releases aren't in sync then you end up with "immortal" PRs |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Tell us more.
Sentry's Electron SDK is often combined with JavaScript framework specific SDKs, however they're shipped in two separate repos, https://github.com/getsentry/sentry-electron and https://github.com/getsentry/sentry-javascript.
The versions of the two are tightly coupled and often lead to TypeScript errors if they don't match (e.g. ystv/badger#534 needed me to manually upgrade
@sentry/react
to match@sentry/electron
).It might be worth adding getsentry/sentry-electron to the sentry-javascript monorepo, or making a separate monorepo with them both, so that upgrades to the two are grouped.
Beta Was this translation helpful? Give feedback.
All reactions