Ansible: can't update galaxy roles when multiple results exist

[Tinyblargon]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Gitea

Please tell us more about your question or problem

In the new ansible galaxy it's possible for a user (namespace) to exist twice. Once from the old galaxy with the name forced to lower case and once from the galaxy with the name exactly as on github.
It has been made so both spellings of the namespace lead to the page.
Example:

• https://galaxy.ansible.com/ui/standalone/roles/Tinyblargon/docker_deploy/
• https://galaxy.ansible.com/ui/standalone/roles/tinyblargon/docker_deploy/

Currently the following code is getting triggered, and causing the role not to be updated:

renovate/lib/modules/datasource/galaxy/index.ts

Lines 54 to 59 in 198de58

	if (body.results.length > 1) {
	logger.warn(
	{ dependency: packageName },
	`Received multiple results from ${galaxyAPIUrl}`,
	);
	return null;

Instead of checking if we received more than one item. Consider items where the the namespace converted to lower case are equal as the same package, and remove them from the list, before we check if we have more than 1 item?

Logs (if relevant)

Logs

WARN: Received multiple results from https://galaxy.ansible.com/api/v1/roles/?owner__username=Tinyblargon&name=docker_deploy (repository=my_repo, dependency=Tinyblargon.docker_deploy)

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

Good luck,

The Renovate team

[Tinyblargon]

I've created a minimal example https://github.com/Tinyblargon/renovate-30166

[rarkins]

Do you have a suggestion for how to resolve it? e.g. if multiple results exist, then merge them all?

[Tinyblargon]

@rarkins

My idea would be:
Before checking if there is more than one result, remove duplicates that, when converted to lower-case are the same.

(Haven't looked at the code's history, and why this warning was originally added)

[rarkins]

Are they duplicates or can they have different data?

[Tinyblargon]

Okay so the namespaces contain different versions of the role.
The real solution is to fix the namespace in ansible-galaxy ansible/galaxy#3335
Nothing has to be done in Renovate.

[rarkins]

Related: #29664