Release notes for Helm monorepo with "{package}-{version}" tags #30169
Replies: 2 comments 1 reply
-
Hi there, Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible. Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues. Please follow these steps:
Good luck, The Renovate team |
Beta Was this translation helpful? Give feedback.
-
I think we could test for depName or packageName here, but if you want us to fix/verify it then we'll need a reproduction repo to test against. Otherwise you are welcome to submit a PR for this yourself. |
Beta Was this translation helpful? Give feedback.
-
What would you like help with?
I think I found a bug
How are you running Renovate?
Self-hosted
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
Renovate 37.425.1 in Kubernetes, GitLab
Please tell us more about your question or problem
We are developing Helm charts in a GitHub monorepo where the release names and tags are structured as
{package}-{version}
, for example, for a chart called "foo" at version 1.2.3, the tag name would befoo-1.2.3
. In a different repo (on a private GitLab instance), these Helm charts are present as OCI helmv3 dependencies. Renovate updates them just fine but does not include release notes.After some digging, I narrowed the code location down to:
renovate/lib/workers/repository/update/pr/changelog/release-notes.ts
Line 172 in da33634
This seems to check for e.g.
ghcr.io/org/charts/foo-1.2.3
(sincepackageName
=ghcr.io/org/charts/foo
according to logs), but should really be checking forfoo-1.2.3
using thedepName
(sincedepName
=foo
).Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions