Release notes for Helm monorepo with "{package}-{version}" tags

[meyfa]

What would you like help with?

I think I found a bug

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

Renovate 37.425.1 in Kubernetes, GitLab

Please tell us more about your question or problem

We are developing Helm charts in a GitHub monorepo where the release names and tags are structured as {package}-{version}, for example, for a chart called "foo" at version 1.2.3, the tag name would be foo-1.2.3. In a different repo (on a private GitLab instance), these Helm charts are present as OCI helmv3 dependencies. Renovate updates them just fine but does not include release notes.

After some digging, I narrowed the code location down to:

renovate/lib/workers/repository/update/pr/changelog/release-notes.ts

Line 172 in da33634

const exactReleaseReg = regEx(`${packageName}[@_-]v?${version}`);

This seems to check for e.g. ghcr.io/org/charts/foo-1.2.3 (since packageName = ghcr.io/org/charts/foo according to logs), but should really be checking for foo-1.2.3 using the depName (since depName = foo).

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

Good luck,

The Renovate team

[rarkins]

I think we could test for depName or packageName here, but if you want us to fix/verify it then we'll need a reproduction repo to test against. Otherwise you are welcome to submit a PR for this yourself.

[usmonster]

I believe this could be the same issue as what's discussed on #29943.

@meyfa, thanks for digging, as I couldn't find in the code where this was happening. I will see if I can digest this a bit and see why release notes are included in some cases (cf. usmonster/renovate-test-helm-charts#19) and not in other similar cases (cf. usmonster/renovate-test-helm-charts#20).