separateMinorPatch but for digests

[smoehrle]

What would you like help with?

Other

How are you running Renovate?

Self-hosted

If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.

GitLab, renovate:37.440.7

Please tell us more about your question or problem

We have set separateMinorPatch to true which works as expected and creates a MR for a patch update even when there is already a minor update. The problem we are facing is, that we have a minor update and a digest update. But because there is a MR for the minor update, there is no MR for the digest update.

Log output looks something like:

DEBUG: packageFiles with updates (...)
       "config": {
         "regex": [
           {
             "deps": [
               {
                 "depName": "registry.example.com/docker/app-base/dev/main",
                 "currentValue": "8.2.22",
                 "currentDigest": "sha256:fe79fc33d440a092be18971fa169ed00d5662c9f2d9c404fbdc317de925f9ffc",
                 "datasource": "docker",
                 "versioning": "loose",
                 "replaceString": "# renovate: datasource=docker depName=registry.example.com/docker/app-base/dev/main versioning=loose\nPHP_DEV_VERSION=8.2.22@sha256:fe79fc33d440a092be18971fa169ed00d5662c9f2d9c404fbdc317de925f9ffc",
                 "updates": [
                   {
                     "bucket": "minor",
                     "newVersion": "8.3.9",
                     "newValue": "8.3.9",
                     "newMajor": 8,
                     "newMinor": 3,
                     "updateType": "minor",
                     "newDigest": "sha256:43dbc13f1d2aee56859adfb5930136c699f79b32d372425d9b30e7bb0c464367",
                     "branchName": "renovate/dockerapp-base"
                   },
                   {
                     "updateType": "digest",
                     "newValue": "8.2.22",
                     "newDigest": "sha256:8129e2d8d6679bfec268f2aaed5c14c4926ce73fa5f63d43ba59e43b805b30d9",
                     "branchName": "renovate/dockerapp-base"
                   }
                 ],
                 "packageName": "registry.example.com/docker/app-base/dev/main",
                 "warnings": [],
                 "registryUrl": "https://registry.example.com",
                 "currentVersion": "8.2.22",
                 "isSingleVersion": true,
                 "fixedVersion": "8.2.22"
               },
[...]

As you can see, the update is detected but there is no MR created.

Logs (if relevant)

Logs

Replace this text with your logs, between the starting and ending triple backticks

[rarkins]

This looks to be as a result of a grouping rule you've added

[smoehrle]

The grouping rule is

    {
      "groupName": "docker/app-base",
      "matchPackagePatterns": [
        "^registry.example.com/docker/app-base"
      ],
      "description": "Allowed versions X.Y.Z or X.Y.Z-A.B.C",
      "allowedVersions": "/^[0-9]+\\.[0-9]+\\.[0-9]+(-[0-9]+\\.[0-9]+\\.[0-9]+)?$/",
      "automerge": true,
      "separateMinorPatch": true
    },

At least for me, it's not obvious what the issue would be. It works for digest, patch, minor updates individually and for the combination of minor+patch updates. But since the MR with the minor update is open, we do not receive digest updates any more.

[rarkins]

If you set automerge=true then you're implicitly saying that you don't care about the separation of updates. The highest update will be created and automerged, and lower ones (including digests) suppressed. There's no point for renovate to create a digest PR of a minor one will be automerge anyway.

[smoehrle]

Ok, makes sense to me. But how do I have to set the config to achieve the goal mentioned in the first post?

My first try was:

    {
      "groupName": "docker/app-base",
      "matchPackagePatterns": [
        "^registry.example.com/docker/app-base"
      ],
      "description": "Allowed versions X.Y.Z or X.Y.Z-A.B.C",
      "allowedVersions": "/^[0-9]+\\.[0-9]+\\.[0-9]+(-[0-9]+\\.[0-9]+\\.[0-9]+)?$/",
      "separateMinorPatch": true
    },
    {
      "groupName": "docker/app-base",
      "matchPackagePatterns": [
        "^registry.example.com/docker/app-base"
      ],
      "description": "Enable automerge only for patch updates, otherwise a minor update stops all other MRs from being created",
      "matchUpdateTypes": ["patch", "pin", "digest"],
      "automerge": true
    },

But this does not work.

The next try was making two completely separate configs but this does not work since "matchUpdateTypes" cannot be combined with "allowedVersions". So something like this, but this is not a valid config

    {
      "groupName": "docker/app-base",
      "matchPackagePatterns": [
        "^registry.example.com/docker/app-base"
      ],
      "allowedVersions": "/^[0-9]+\\.[0-9]+\\.[0-9]+(-[0-9]+\\.[0-9]+\\.[0-9]+)?$/",
      "matchUpdateTypes": ["major", "minor"]
    },
    {
      "groupName": "docker/app-base-patch",
      "matchPackagePatterns": [
        "^registry.example.com/docker/app-base"
      ],
      "matchUpdateTypes": ["patch", "pin", "digest"],
      "allowedVersions": "/^[0-9]+\\.[0-9]+\\.[0-9]+(-[0-9]+\\.[0-9]+\\.[0-9]+)?$/",
      "automerge": true
    },

And deleting allowedVersions is not an option since otherwise I receive updates for tags I do not want. Any help or hint is appreciated

[github-actions[bot]]

Hi there,

Get your discussion fixed faster by creating a minimal reproduction. This means a repository dedicated to reproducing this issue with the minimal dependencies and config possible.

Before we start working on your issue we need to know exactly what's causing the current behavior. A minimal reproduction helps us with this. Discussions without reproductions are less likely to be converted to Issues.

Please follow these steps:

1. Read our guide on creating a minimal reproduction.
2. Go to our minimal reproduction template repository.
3. Select the Use this template button to create a new repository based on the template.
4. Work on the minimal reproduction in your own repository.
5. Fill out the information in your repository's README.md.
6. Add the link to your reproduction to the first post of your Discussion. If you are not the original author, you can post a new comment with the link.

Good luck,

The Renovate team