bundle --strict prevents updates from actually happening #33446
Replies: 5 comments 4 replies
-
I also noticed some curious pull requests where the changes do not match the title: This might be a different issue, but related |
Beta Was this translation helpful? Give feedback.
-
I just noticed I hadn't push the Gemfile to the reproduction repo. Added it now. |
Beta Was this translation helpful? Give feedback.
-
I removed the It appears correct, but I'd like to understand first why the It was added by @Timmitry in https://github.com/renovatebot/renovate/pull/19446/files#diff-c133087098907267d023ccaad38b68c2322b6d1cce6e250268a56b5437c06bd2 following this discussion: #19417 |
Beta Was this translation helpful? Give feedback.
-
@mxey @rarkins I'll try to help here, even though this was my one-time contribution to renovate, and I'm not really an expert in this matter 🙃 First of all: You say renovate runs
So together, they prevent ANY minor or major updates for any dependency, even for subdependencies. So the behaviour of bundler for this command is correct, it can't update With the |
Beta Was this translation helpful? Give feedback.
-
Converted to issue #33508 |
Beta Was this translation helpful? Give feedback.
-
How are you running Renovate?
Self-hosted Renovate
If you're self-hosting Renovate, tell us which platform (GitHub, GitLab, etc) and which version of Renovate.
Gitlab
renovate/renovate:39.92.0
Please tell us more about your question or problem
When Renovate detects updates for dependencies in a Bundler Gemfile.lock, it runs
bundler lock --patch --strict --update $GEM
to perform the change. However, the--strict
option prevents Bundler from bumping anything more than patch level. If the gem in question changes it dependencies to a higher minor, the whole change will be skipped.Reproduction - I have not managed to quickly get Renovate to run on Github, so I put this repo on our Gitlab and run Renovate against that, as usual. I don't think that makes a difference.
You can see in the logs that Renovate runs
bundler
and then realizes that there are no changes:I can reproduce Bundler's behavior manually as well:
As you can see,
bolt
required a major update to fullfil the depedencies forpuppet_litmus
Logs (if relevant)
Logs
Beta Was this translation helpful? Give feedback.
All reactions