Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renovate create the pull request too early when there are a lot of packages sharing the same version #12133

Closed
JavierSegoviaCordoba opened this issue Oct 12, 2021 · 6 comments
Labels
status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality

Comments

@JavierSegoviaCordoba
Copy link
Contributor

How are you running Renovate?

WhiteSource Renovate hosted app on github.com

Please select which platform you are using if self-hosting.

No response

If you're self-hosting Renovate, tell us what version of Renovate you run.

No response

Describe the bug

In Gradle Plugins repo, I have like 10-20 projects sharing the same version, but Renovate is not waiting until all projects are available in the remote repositories to create the PR.

As this PR is created too early, it fails because some of the packages are available with the new version, but others are only available with the older version until the next 5-15 minutes. So I have to rerun the GitHub workflow manually or select the PR to be rebased.

Relevant debug logs

Logs
Copy/paste any log here, between the starting and ending backticks

Have you created a minimal reproduction repository?

No reproduction, but I have linked to a public repo where it occurs

@JavierSegoviaCordoba JavierSegoviaCordoba added priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality labels Oct 12, 2021
@rarkins
Copy link
Collaborator

rarkins commented Oct 12, 2021

Try setting stabilityDays=1

@JavierSegoviaCordoba
Copy link
Contributor Author

Is it possible to change this one to be in hours or minutes?

If not, should I create a feature request for this one?

stabilityHours=1 or stabilityMinutes=30

@rarkins
Copy link
Collaborator

rarkins commented Oct 15, 2021

It would need code changes, but I am happy for us to do it. Ideal for me would be:

  • Rename it to be a bit more generic (e.g. "releaseDelay", but better)
  • We retire/migrate stabilityDays
  • Define a simple format for duration - or find one which already exists - so that it can be e.g. 1d2h3m. We might find use for such a format elsewhere

@JavierSegoviaCordoba
Copy link
Contributor Author

I like your idea and it is better to have only one property

@HonkingGoose
Copy link
Collaborator

We have another open issue 1 that's about "waiting until all dependencies in a group have new versions before opening/merging PR". It sounds similar in concept:

The use case here is that you still want fast updates, but you don't want to open a PR for a group until some required deps have new versions, ensuring they are always updated together.

I also found a issue that wants to "force same versions inside package group", which also sounds related. 2

I don't know which issues we want to keep/close.

I'll let @rarkins decide what to do with each issue. 😉

Footnotes

  1. https://github.com/renovatebot/renovate/issues/9739

  2. https://github.com/renovatebot/renovate/issues/12310

@rarkins
Copy link
Collaborator

rarkins commented Nov 10, 2021

Duplicate of #12310

@rarkins rarkins closed this as completed Nov 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status:requirements Full requirements are not yet known, so implementation should not be started type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

3 participants