Lerna support with binarySource: 'install'

[HeadFox]

What would you like Renovate to be able to do?

I would like renovate to support binarySource install mode with Lerna to allow dynamic version of npm to be installed.

If you have any ideas on how this should be implemented, please tell us here.

#12598
This PR was a start but it was closed after. If you need help on this, it will be a pleasure for me to help :)

Is this a feature you are interested in implementing yourself?

Yes

[github-actions]

Hi there,

Help us by making a minimal reproduction repository.

Before we can start work on your issue we first need to know exactly what's causing the current behavior. A minimal reproduction helps us with this.

To get started, please read our guide on creating a minimal reproduction to understand what is needed.

We may close the issue if you (or someone else) have not provided a minimal reproduction within two weeks. If you need more time, or are stuck, please ask for help or more time in a comment.

Good luck,

The Renovate team

[rarkins]

A reproduction repository to test against would be helpful

[HeadFox]

Reproduction repo : https://github.com/HeadFox/reproduce-lerna-renovate
PR : https://github.com/HeadFox/reproduce-lerna-renovate/pull/1
The PR opened changed the lockfile to v1
Self hosted renovate is using renovate/renovate:31.21.0 official image.
Here is the config.js from the self-hosted renovate:

module.exports = {
    gitAuthor: 'Renovate Bot <lpeslier@meilleursagents.com>',
    platform: 'github',
    labels: ['renovate'],
    logFileLevel: 'debug',
    logFile: '/tmp/renovate.log',
    onboarding: true,
    autodiscover: true,
    autodiscoverFilter: "HeadFox/reproduce-lerna-renovate",
    baseBranches: ['master'],
    onboardingConfigFileName: ".github/renovate.json",
    onboardingPrTitle: "chore: configure renovate",
    onboardingCommitMessage: "chore(renovate): configure renovate",
    binarySource: "install",
    enabledManagers: [
        'npm',
    ],
};

We don't have any issue with binarySource: install on normal repos without lerna
Part of log :

DEBUG: Using lerna version ^4.0.0 (repository=HeadFox/reproduce-lerna-renovate, branch=renovate/eslint-8.x)
DEBUG: Executing command (repository=HeadFox/reproduce-lerna-renovate, branch=renovate/eslint-8.x)
       "command": "lerna info || echo \"Ignoring lerna info failure\""
DEBUG: exec completed (repository=HeadFox/reproduce-lerna-renovate, branch=renovate/eslint-8.x)
       "cmd": "lerna info || echo \"Ignoring lerna info failure\"",
       "durationMs": 1319,
       "stdout": "\n Environment info:\n\n  System:\n    OS: Linux 4.19 Ubuntu 20.04.3 LTS (Focal Fossa)\n    CPU: (4) x64 Intel(R) Xeon(R) CPU @ 2.30GHz\n  Binaries:\n    Node: 14.18.2 - /usr/local/bin/node\n    Yarn: 1.22.17 - /usr/local/bin/yarn\n    npm: 6.14.15 - /usr/local/bin/npm\n  Utilities:\n    Git: 2.34.1 - /usr/bin/git\n\n",
       "stderr": "lerna notice cli v4.0.0\n"
DEBUG: Executing command (repository=HeadFox/reproduce-lerna-renovate, branch=renovate/eslint-8.x)
       "command": "npm install --ignore-scripts  --no-audit --package-lock-only"
DEBUG: exec completed (repository=HeadFox/reproduce-lerna-renovate, branch=renovate/eslint-8.x)
       "cmd": "npm install --ignore-scripts  --no-audit --package-lock-only",
       "durationMs": 3232,
       "stdout": "added 619 packages in 1.994s\n",
       "stderr": "npm WARN read-shrinkwrap This version of npm is compatible with lockfileVersion@1, but package-lock.json was generated for lockfileVersion@2. I'll try to do my best with it!\nnpm WARN reproduce-lerna-renovate@1.0.0 No description\nnpm WARN reproduce-lerna-renovate@1.0.0 No repository field.\n\n"

[HeadFox]

This file in renovate https://github.com/renovatebot/renovate/blob/main/lib/manager/npm/post-update/lerna.ts is only supporting binarySource: docker as I can see

[viceice]

@HeadFox Youre reproduction is gone, can you please recreate it, so i can fork and test against?

[viceice]

https://github.com/renovate-reproductions/13599-lerna-buildpack
https://github.com/renovate-reproductions/13599-lerna-buildpack-npm

[renovate-release]

🎉 This issue has been resolved in version 32.148.0 🎉

The release is available on:

• GitHub release
• 32.148.0

Your semantic-release bot 📦🚀