Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support binarySource=install for cargo #13685

Closed
rarkins opened this issue Jan 20, 2022 · 3 comments
Closed

Support binarySource=install for cargo #13685

rarkins opened this issue Jan 20, 2022 · 3 comments
Labels
manager:cargo Cargo/Rust/crates.io priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)

Comments

@rarkins
Copy link
Collaborator

rarkins commented Jan 20, 2022

What would you like Renovate to be able to do?

Allow dynamic switching of cargo version at runtime

If you have any ideas on how this should be implemented, please tell us here.

It seems like we don't dynamically install cargo today, so maybe there is nothing to be done:

let cmd = `cargo update --manifest-path ${quote(manifestPath)}`;
// If we're updating a specific crate, `cargo-update` requires `--workspace`
// for more information, see: https://github.com/renovatebot/renovate/issues/12332
if (!isLockFileMaintenance) {
cmd += ` --workspace`;
}
const execOptions: ExecOptions = {
docker: {
image: 'rust',
},
};
await exec(cmd, execOptions);

If so then we should note this here for the record before closing.

Is this a feature you are interested in implementing yourself?

Maybe

@rarkins rarkins added type:feature Feature (new functionality) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:cargo Cargo/Rust/crates.io status:requirements Full requirements are not yet known, so implementation should not be started labels Jan 20, 2022
@viceice
Copy link
Member

viceice commented Jan 20, 2022

Maybe allow installing rust dynamically? So it can also use for runtime install mode?

@rarkins
Copy link
Collaborator Author

rarkins commented Jan 20, 2022

Yes, but I was thinking to do all the managers first and then languages in second phase

@viceice
Copy link
Member

viceice commented Jan 20, 2022

ok, so cargo is included in rust so nothing to do here.

@rarkins rarkins closed this as completed Jan 20, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:cargo Cargo/Rust/crates.io priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others status:requirements Full requirements are not yet known, so implementation should not be started type:feature Feature (new functionality)
Projects
None yet
Development

No branches or pull requests

2 participants