Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple PRs autoclosed and then new PRs opened #1785

Closed
2 of 7 tasks
edmorley opened this issue Apr 4, 2018 · 2 comments
Closed
2 of 7 tasks

Multiple PRs autoclosed and then new PRs opened #1785

edmorley opened this issue Apr 4, 2018 · 2 comments
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@edmorley
Copy link
Contributor

edmorley commented Apr 4, 2018

This is a:

  • Bug report (non-security related)
  • Feature request
  • I'm not sure which of those it is

I'm using:

  • The Renovate GitHub App
  • Self-hosted GitHub
  • Self-hosted GitLab
  • Self-hosted VSTS

Please describe the issue:

Hi :-)

While I was away, Renovate autoclosed these unmerged PRs:
neutrinojs/neutrino#631
neutrinojs/neutrino#712
neutrinojs/neutrino#718
neutrinojs/neutrino#719
neutrinojs/neutrino#724
neutrinojs/neutrino#733

And then later opened new PRs matching those that were closed:
neutrinojs/neutrino#765
neutrinojs/neutrino#766
neutrinojs/neutrino#767
neutrinojs/neutrino#768
neutrinojs/neutrino#769
neutrinojs/neutrino#770

I don't believe we did anything to cause this (eg we didn't delete the branches), so this seems like a bug?

@rarkins rarkins added type:bug Bug fix of existing functionality needs-requirements priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Apr 4, 2018
@rarkins
Copy link
Collaborator

rarkins commented Apr 4, 2018

@edmorley thanks for the detailed report and sorry for the inconvenience. It seems that during one run only, Renovate couldn't detect all the npm package files:

{"repository":"mozilla-neutrino/neutrino-dev","manager":"npm","files":["package.json"],"msg":"Detected package files","time":"2018-03-26T22:12:23.979Z"}

Yet in the runs before and after, they were detected. I've checked the logs and we had no abnormally high count of autoclosing around that time either.

I've added a debug to log how many total files are detected each run, which can help narrow it down if it happens again - presumably it's an incorrect file list somehow. I might also add a repository state cleanup at the end of each run in case there's some global pollution randomly happening.

I'll keep this issue open until either one day I understand why it happened, or it's been so long since it happened that I give up.

@edmorley
Copy link
Contributor Author

edmorley commented Apr 4, 2018

Thank you for taking a look & adding the debug logging. Happy to close this out until/if it happens again, if you'd prefer :-)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants