Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release notes: compare link using commit instead of tag #1963

Closed
rarkins opened this issue May 13, 2018 · 4 comments
Closed

release notes: compare link using commit instead of tag #1963

rarkins opened this issue May 13, 2018 · 4 comments
Assignees
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality

Comments

@rarkins
Copy link
Collaborator

rarkins commented May 13, 2018

I was checking logs and noticed that this PR was updated unexpectedly: schulzetenberg/data-collector#41

A manual inspect of PR body showed that a compare of v6.0.0...v6.0.1 was updated to v6.0.0...b9c40eef3cb0c0e4a25b4806a530e3bb8a2c7483:
image

I tried reproducing it here but could not: renovate-tests/changelog1#1

I wonder if the failure to reproduce or even the problem itself could be related to timezones - Renovate App's servers are on west coast USA while I'm in Europe.

Either way, it shouldn't depend on time zones because if the tag exists then it should be used, regardless of time.

Here's another example: MCS-Lite/mcs-lite#623
Another: klis87/redux-requests#110 (this one has the from as commit and not to)

@rarkins rarkins added type:bug Bug fix of existing functionality ready priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others manager:npm package.json files (npm/yarn/pnpm) labels May 13, 2018
@rarkins
Copy link
Collaborator Author

rarkins commented May 13, 2018

logs:

{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"args":{"manager":"npm","depType":"devDependencies","depName":"@angular/cli","fromVersion":"1.7.4","newVersion":"6.0.1"},"msg":"getChangeLogJSON(args)","time":"2018-05-13T13:35:47.821Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"GET https://api.github.com/repos/angular/angular-cli/contents/ [retries=5]","time":"2018-05-13T13:35:47.822Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"getReleaseNotes(angular/angular-cli, 6.0.1)","time":"2018-05-13T13:35:47.978Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"getReleaseList()","time":"2018-05-13T13:35:47.978Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"GET https://api.github.com/repos/angular/angular-cli/releases?per_page=100 [retries=5]","time":"2018-05-13T13:35:47.978Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"getReleaseNotes(angular/angular-cli, 6.0.0)","time":"2018-05-13T13:35:48.338Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"getReleaseList()","time":"2018-05-13T13:35:48.338Z"}
{"level":20,"repository":"schulzetenberg/data-collector","branch":"renovate/angular-cli-6.x","dependencies":["@angular/cli"],"msg":"Processing existing PR","time":"2018-05-13T13:35:48.362Z"}

The fromVersion looks wrong in the above, but what we see in the PR seems to be right.

@rarkins
Copy link
Collaborator Author

rarkins commented May 13, 2018

I also noticed a strange link here: spartha1995/Crud-Operation-Angular-2-#59

For v6.0.0 the link is ReactiveX/rxjs@6.0.0-uncanny-rc.7...6.0.0

I would have expected it to be 5.5.10...6.0.0

@rarkins rarkins added blocked and removed ready labels May 15, 2018
@kayoub5
Copy link
Contributor

kayoub5 commented Jun 14, 2018

@rarkins is this still happening?

@rarkins
Copy link
Collaborator Author

rarkins commented Jun 14, 2018

Now fixed

@rarkins rarkins closed this as completed Jun 14, 2018
@rarkins rarkins removed the blocked label Jun 14, 2018
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
manager:npm package.json files (npm/yarn/pnpm) priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:bug Bug fix of existing functionality
Projects
None yet
Development

No branches or pull requests

2 participants