-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update labels when config changes #22496
Comments
Duplicate of #9950 ? |
Seems to be related, but a different idea. Perhaps we use my idea above but could add a new option |
i think you are inviting more problems and complexity by deciding if it is updated manually or by renovate, |
Reasons:
Hence we need to be able to distinguish between these two cases:
|
In that case we should basically add a hidden string inside of PRs/Issues to save the last applied labels. |
A hidden string would be simpler, a hash of that string would be shorter |
If we use pr-comments we can only enable this feature for Update: We can handle azure but there is a catch:
|
Actually if the "hidden strings" are short hashes, I think we could make them non-hidden for platforms which don't support html comments if the functional benefits outweigh the "costs" (extra lines in the PR description) |
Okay, also it has to be done in 2 PRs so that the hash is added to all existing PRs before we start adding/removing labels. |
We should only reapply labels to existing PRs if that PR was created with a label hash, so that we don't annoy users who have removed labels |
Is this not ready? |
We no longer use |
Describe the proposed change(s).
Renovate should be able to support changing of labels in an existing PR, as long as the user hasn't modified the labels Renovate originally added.
We don't want to be in a situation where users remove/change labels and Renovate keeps putting them back. To avoid that, we can potentially embed a hash in the PR body which records which labels were added to the PR originally, or when they were last updated. If all such labels are still in the PR, then we should be free to update/sync the labels (including adding and removing).
Describe why we need/want these change(s).
Examples:
It's unintuitive today why changes can't be made in these situations.
The text was updated successfully, but these errors were encountered: