-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vendir): add vendir support #25113
feat(vendir): add vendir support #25113
Conversation
Currently only supports the helmChart dependency, but provides a framework for other types of dependencies in vendir Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>
@rarkins I think I have this mostly working (working through some final small things). But I would love a cursory glance. I also would love to know how the kustomize manager works. I used the kustomize and helmv3 managers as examples. What I didn't see in the case of kustomize but did in the case of helmv3 is a bumpVersion function. Where does that happen for kustomize? Do I need to write a bumpVersion function? Or does the new version just show up somewhere properly? And I can't get the tests to pass for artifact.ts. I appear to be having a problem with adding all non-vendir.lock.yml files. I tried both the kustomize, helm, and gomod method and cannot get it to work properly. Can you give me some pointers on that? |
feat(vendir): check types correctly Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>
@rarkins would love some feedback on this PR, would love to get vendir support added natively |
chore: revert package.json change chore: run prettier
fix: inline function fix: remove resetAllMocks Co-authored-by: Zoltán Reegn <reegnz@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
Co-authored-by: HonkingGoose <34918129+HonkingGoose@users.noreply.github.com>
fix: add back conditional for vendirSync properly docs: update vendir readme
8151a04
to
49ad5c7
Compare
please avoid force push, we squash merge, so no worries about git history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work, nearly done
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
fix: remove unnecessary check fix: remove utils tests: update tests results to reflect better naming tests: inline emptydirectories
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
🎉 This PR is included in version 37.264.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Currently only supports the helmChart dependency, but provides a framework for other types of dependencies in vendir
Changes
Context
Closes #17711
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via:
Test PRs:
Example Onboarding PR with Vendir showing it finding/discovering helm charts properly
Example Update with https
Example update with OCI