Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: build renovate docker images on release #26108

Merged
merged 9 commits into from
Jan 17, 2024
Merged

Conversation

viceice
Copy link
Member

@viceice viceice commented Dec 4, 2023

Changes

Build our renovate images after the npm release

Context

requires those to be merged before:

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified unit tests, or
  • No unit tests but ran on a real repository, or
  • Both unit tests + ran on a real repository

@viceice viceice requested a review from rarkins December 4, 2023 14:53
Copy link
Collaborator

@secustor secustor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far

@viceice viceice marked this pull request as ready for review January 15, 2024 10:40
@viceice viceice requested a review from secustor January 15, 2024 10:40
@rarkins
Copy link
Collaborator

rarkins commented Jan 15, 2024

Do you anticipate having any "race conditions" where you publish version x.y.z to npmjs and then the corresponding Docker image fails to install the same version because the npmjs CDN says it's not available?

Is it already the case that every version we publish to npm will have a corresponding version on Docker? i.e. GitHub doesn't cancel duplicate workflows, and if a Docker publish fails after npm publish succeeds, is there a way to recover?

Do we have a nice way to roll forward and back with this approach after merge if we find problems?

@viceice
Copy link
Member Author

viceice commented Jan 15, 2024

Do you anticipate having any "race conditions" where you publish version x.y.z to npmjs and then the corresponding Docker image fails to install the same version because the npmjs CDN says it's not available?

🤔 Didn't thought about that yet.

Is it already the case that every version we publish to npm will have a corresponding version on Docker? i.e. GitHub doesn't cancel duplicate workflows, and if a Docker publish fails after npm publish succeeds, is there a way to recover?

We don't publish all versions to docker yet, because the current images are not updated that often and we only rebuild last version.

Do we have a nice way to roll forward and back with this approach after merge if we find problems?

Currently the docker images are not published. I've disabled to just test the docker build on release.
If build succeeds fine, the we can enable image publishing in a new PR. If build fails because of npmjs issues, then we can revert / or fix the build first by another approach. (not using npmjs renovate, but using a local build)

rarkins
rarkins previously approved these changes Jan 16, 2024
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Outdated Show resolved Hide resolved
.github/workflows/release.yml Show resolved Hide resolved
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@viceice viceice added this pull request to the merge queue Jan 17, 2024
Merged via the queue into main with commit 5ca375a Jan 17, 2024
36 checks passed
@viceice viceice deleted the build/docker-images branch January 17, 2024 09:33
@renovate-release
Copy link
Collaborator

🎉 This PR is included in version 37.139.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 22, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
zT-1337 pushed a commit to scm-manager/renovate that referenced this pull request Jan 24, 2024
Co-authored-by: Sebastian Poxhofer <secustor@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants