-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(matchConfidence): align supported datasources list with internal preset #26420
fix(matchConfidence): align supported datasources list with internal preset #26420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if you use the environment variable then the preset is again out of sync with the real config.
do we really need the configuration via environment?
Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…aretti/renovate into fix/mc_support_List
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry
What prevents this from being merged 🤔? |
needs @rarkins review 🤗 |
🎉 This PR is included in version 37.107.2 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
…preset (renovatebot#26420) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…preset (renovatebot#26420) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
…preset (renovatebot#26420) Co-authored-by: Michael Kriese <michael.kriese@visualon.de>
Changes
The current implementation of the
getConfidenceLevel
function uses a hardcoded list of supported datasources. This list is used to filter requests to the backend, ensuring that only supported datasources result in an actual API call.However, the current list is out of sync with the internal badges preset. In this PR, these two lists are combined into a single source of truth.
Additionally, an experimental feature flag has been added for internal use, allowing the overriding of the list for the
getConfidenceLeve
function.Context
Documentation (please check one with an [x])
How I've tested my work (please select one)
I have verified these changes via: